Skip to content

Small grammar, punctuation, and code style improvements to docs #6361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 22, 2020

Conversation

carols10cents
Copy link
Member

changelog: Made small grammar, punctuation, and code style improvements to docs

I recently found some places in rust-lang/rust that had lists without spaces after commas, which led me to look for more places, which led me over here to find:

  • Some similar lists in code examples that could use spaces after commas to be idiomatic Rust style
  • Some lists in documentation text that didn't have spaces after commas, needed an Oxford comma (fight me), or were otherwise misformatted
  • Some other grammar improvements in the area of the other changes

These changes should only be in user-facing documentation or output.

@rust-highfive
Copy link

r? @Manishearth

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 21, 2020
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a native speaker, so I leave the decision about that/which to you. For me it sounds exactly the same. 😄

@flip1995
Copy link
Member

You'll have to run cargo dev update_lints in the Clippy directory once though.

@bors delegate+

@bors
Copy link
Contributor

bors commented Nov 22, 2020

✌️ @carols10cents can now approve this pull request

@carols10cents
Copy link
Member Author

Whoops, sorry about that! I think I've fixed everything, sooooo

@bors r+

@bors
Copy link
Contributor

bors commented Nov 22, 2020

📌 Commit 445466e has been approved by carols10cents

@bors
Copy link
Contributor

bors commented Nov 22, 2020

⌛ Testing commit 445466e with merge 3e7c6de...

@bors
Copy link
Contributor

bors commented Nov 22, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: carols10cents
Pushing 3e7c6de to master...

@bors bors merged commit 3e7c6de into rust-lang:master Nov 22, 2020
@carols10cents carols10cents deleted the doc-style branch November 22, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants