Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add derive_ord_xor_partial_ord lint #5848

Merged
merged 12 commits into from
Aug 4, 2020
Merged

Add derive_ord_xor_partial_ord lint #5848

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5a64496
run cargo dev new_lint
Ryan1729 Jul 27, 2020
fc20ee6
move derive_ord_xor_partial_ord into derive mod so we can reuse deriv…
Ryan1729 Jul 27, 2020
0722991
add test for derive_ord_xor_partial_ord based on test for derive_hash…
Ryan1729 Jul 27, 2020
068acbd
initial implementation based on code for `derive_hash_xor_partial_eq`…
Ryan1729 Jul 27, 2020
a8d6eda
use get_trait_def_id to check for Ord trait
Ryan1729 Jul 27, 2020
6c3e459
update reference since we see the expected four errors
Ryan1729 Jul 27, 2020
7dc9748
remove is_local check since getting the def_id directly makes it unne…
Ryan1729 Jul 27, 2020
431924c
add description for derive_ord_xor_partial_ord
Ryan1729 Jul 27, 2020
668b747
run cargo dev fmt and fix overly long line
Ryan1729 Jul 27, 2020
ca03f2b
s/pord/partial_ord/ to fix dogfood failure
Ryan1729 Jul 27, 2020
12a6eee
fill in lint description for DERIVE_ORD_XOR_PARTIAL_ORD
Ryan1729 Jul 27, 2020
94b10a6
run cargo dev update_lints
Ryan1729 Jul 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
run cargo dev fmt and fix overly long line
  • Loading branch information
@Ryan1729
Ryan1729 committed Jul 27, 2020
commit 668b7474b47791c8c9af10130356b681b3bf3a84
10 changes: 8 additions & 2 deletions clippy_lints/src/derive.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
use crate::utils::paths;
use crate::utils::{
get_trait_def_id, is_automatically_derived, is_copy, match_path, span_lint_and_help, span_lint_and_note, span_lint_and_then,
get_trait_def_id, is_automatically_derived, is_copy, match_path, span_lint_and_help, span_lint_and_note,
span_lint_and_then,
};
use if_chain::if_chain;
use rustc_hir::def_id::DefId;
Expand Down Expand Up @@ -154,7 +155,12 @@ declare_clippy_lint! {
"deriving `serde::Deserialize` on a type that has methods using `unsafe`"
}

declare_lint_pass!(Derive => [EXPL_IMPL_CLONE_ON_COPY, DERIVE_HASH_XOR_EQ, DERIVE_ORD_XOR_PARTIAL_ORD, UNSAFE_DERIVE_DESERIALIZE]);
declare_lint_pass!(Derive => [
EXPL_IMPL_CLONE_ON_COPY,
DERIVE_HASH_XOR_EQ,
DERIVE_ORD_XOR_PARTIAL_ORD,
UNSAFE_DERIVE_DESERIALIZE
]);

impl<'tcx> LateLintPass<'tcx> for Derive {
fn check_item(&mut self, cx: &LateContext<'tcx>, item: &'tcx Item<'_>) {
Expand Down
2 changes: 1 addition & 1 deletion tests/ui/derive_ord_xor_partial_ord.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,4 @@ mod use_ord {
}
}

fn main() {}
fn main() {}