Merged
Conversation
Context: this is needed to fix rust-lang/rustfmt#4263, which currently records the span of a const generic param incorrectly because the location of the `const` kw is not known. I am not sure how to add tests for this; any guidance in how to do so would be appreciated 🙂
Record span of `const` kw in GenericParamKind Context: this is needed for a fix of rust-lang/rustfmt#4263, which currently records the span of a const generic param incorrectly because the location of the `const` kw is not known. I am not sure how to add tests for this; any guidance in how to do so would be appreciated 🙂
Rollup of 13 pull requests Successful merges: - #72620 (Omit DW_AT_linkage_name when it is the same as DW_AT_name) - #72967 (Don't move cursor in search box when using arrows to navigate results) - #73102 (proc_macro: Stop flattening groups with dummy spans) - #73297 (Support configurable deny-warnings for all in-tree crates.) - #73507 (Cleanup MinGW LLVM linkage workaround) - #73588 (Fix handling of reserved registers for ARM inline asm) - #73597 (Record span of `const` kw in GenericParamKind) - #73629 (Make AssocOp Copy) - #73681 (Update Chalk to 0.14) - #73707 (Fix links in `SliceIndex` documentation) - #73719 (emitter: column width defaults to 140) - #73729 (disable collectionbenches for android) - #73748 (Add code block to code in documentation of `List::rebase_onto`) Failed merges: r? @ghost
rust-highfive
added
the
S-waiting-on-review
Member
|
@bors r+ |
Contributor
|
📌 Commit 50ff06a has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Jun 26, 2020
Rustup cc rust-lang/rust#73743 r? @Manishearth changelog: none
Contributor
|
💔 Test failed - checks-action_test |
flip1995
force-pushed
the
rustup
branch
2 times, most recently
from
f65ae52 to
add515f
Compare
Member
Author
|
@bors r=Manishearth |
Contributor
|
📌 Commit add515f has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Jun 28, 2020
Rustup cc rust-lang/rust#73743 r? @Manishearth changelog: none
Contributor
|
💔 Test failed - checks-action_test |
Member
Author
|
@bors r=Manishearth,flip1995 |
Contributor
|
📌 Commit d1ab534 has been approved by |
bors
added a commit
that referenced
this pull request
Jun 30, 2020
Rustup cc rust-lang/rust#73743 r? @Manishearth changelog: none
Contributor
Member
Author
|
@bors r=Manishearth,flip1995 |
Contributor
|
📌 Commit ab649c9 has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This was referenced Jun 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc rust-lang/rust#73743
r? @Manishearth
changelog: none