Zero single char names #5468
Merged
Zero single char names #5468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
approved these changes
Apr 15, 2020
Member
flip1995
left a comment
flip1995
left a comment
There was a problem hiding this comment.
Thanks! You can just wait for the rustup.
flip1995
added
the
S-waiting-on-bors
flip1995
requested changes
Apr 15, 2020
tests/ui/many_single_char_names.rs
Outdated
| #[warn(clippy::many_single_char_names)] | ||
|
|
||
| fn bla() { | ||
| let x: i32; |
Member
There was a problem hiding this comment.
I'd rather lower the default threshold by one, than modifying the test.
rust-clippy/clippy_lints/src/utils/conf.rs
Lines 137 to 138 in c496f4e
(the documentation of this config param is now more correct than before 😄)
flip1995
added
S-waiting-on-author
flip1995
approved these changes
Apr 15, 2020
flip1995
added
S-waiting-on-bors
Member
|
@bors r+ rollup |
Contributor
|
📌 Commit ce372c1 has been approved by |
Contributor
|
🌲 The tree is currently closed for pull requests below priority 1, this pull request will be tested once the tree is reopened |
bors
added a commit
that referenced
this pull request
Apr 15, 2020
Rollup of 5 pull requests Successful merges: - #5226 (Add lint for explicit deref and deref_mut method calls) - #5248 (Add lint on large non scalar const) - #5430 (Disallow bit-shifting in integer_arithmetic) - #5466 (large_enum_variant: Report sizes of variants) - #5468 (Zero single char names) Failed merges: r? @ghost changelog: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4086
changelog: