Improve docs for option_option #5403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hint about using tri-state enums to replace legitimate uses of `Option<Option<_>>`
flip1995
reviewed
Apr 2, 2020
flip1995
added
the
S-waiting-on-author
flip1995
reviewed
Apr 2, 2020
Co-Authored-By: Philipp Krones <hello@philkrones.com>
flip1995
added
S-waiting-on-review
Member
|
@bors r+ Thanks! |
Contributor
|
📌 Commit 5f8b696 has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hint about using tri-state enums to replace legitimate uses of
Option<Option<_>>changelog: The docs for
option_optionnow suggest using a tri-state enum