Skip to content

Conversation

@tesuji
Copy link
Contributor

@tesuji tesuji commented Mar 29, 2020

Closes #5346
changelog: Deprecate replace_consts lint

@tesuji tesuji force-pushed the deprecate-REPLACE_CONSTS branch 4 times, most recently from 7e35a74 to d055b7d Compare March 29, 2020 05:58
@phansch
Copy link
Contributor

phansch commented Mar 30, 2020

This also closes #2380 then :)

Copy link
Contributor

@phansch phansch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me once #5390 is merged

@phansch
Copy link
Contributor

phansch commented Mar 30, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Mar 30, 2020

📌 Commit d055b7d has been approved by phansch

@bors
Copy link
Contributor

bors commented Mar 30, 2020

⌛ Testing commit d055b7d with merge bfd1123...

@bors
Copy link
Contributor

bors commented Mar 30, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: phansch
Pushing bfd1123 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove/Deprecate the REPLACE_CONSTS lints

3 participants