Skip to content

Detect usage of custom floating-point abs implementation #5246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 12 commits into from
Mar 4, 2020
Merged

Detect usage of custom floating-point abs implementation #5246

bors merged 12 commits into from
Mar 4, 2020

Conversation

@JarredAllen
Copy link
Contributor

@JarredAllen JarredAllen commented Mar 1, 2020 •
edited by flip1995
Loading

Closes #5224

changelog: Enhance [suboptimal_flops] lint to detect manual implementations of the abs method

@JarredAllen
Copy link
Contributor Author

JarredAllen commented Mar 1, 2020

On my machine, there were already 6 tests that failed before I made any changes to the code. I imagine that's probably what the failing check is.

@JohnTitor
Copy link
Member

JohnTitor commented Mar 1, 2020

On my machine, there were already 6 tests that failed before I made any changes to the code. I imagine that's probably what the failing check is.

The failure is #5238, you can ignore them for now.

@JarredAllen
Copy link
Contributor Author

JarredAllen commented Mar 1, 2020

The most recent commit was because running cargo dev fmt reformatted the test case that I wrote, so I had to adjust the linter outputs, and I didn't expect that to happen so I hadn't tried running the test again.

@bors
Copy link
Contributor

bors commented Mar 1, 2020

☔ The latest upstream changes (presumably #5247) made this pull request unmergeable. Please resolve the merge conflicts.

krishna-veerareddy
krishna-veerareddy reviewed Mar 1, 2020
View reviewed changes
@JohnTitor JohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 2, 2020
flip1995
flip1995 requested changes Mar 3, 2020
View reviewed changes
@flip1995 flip1995 added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Mar 3, 2020
@JarredAllen
Copy link
Contributor Author

JarredAllen commented Mar 3, 2020

@flip1995 I think I implemented all of your suggested changes.

@flip1995 flip1995 added S-waiting-on-bors Status: The marked PR was approved and is only waiting bors and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Mar 4, 2020
@flip1995
Copy link
Member

flip1995 commented Mar 4, 2020

cargo dev fmt and waiting for the rustup and this is good to go 👍

@phansch
Copy link
Contributor

phansch commented Mar 4, 2020

@bors r=flip1995

@bors
Copy link
Contributor

bors commented Mar 4, 2020

📌 Commit c3e96d1 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Mar 4, 2020

⌛ Testing commit c3e96d1 with merge b900228...

bors added a commit that referenced this pull request Mar 4, 2020
@bors
Auto merge of #5246 - JarredAllen:master, r=flip1995
b900228 
Detect usage of custom floating-point abs implementation

Implements #5224
@bors
Copy link
Contributor

bors commented Mar 4, 2020

💔 Test failed - checks-action_test

@flip1995
Copy link
Member

flip1995 commented Mar 4, 2020

@bors retry

@bors
Copy link
Contributor

bors commented Mar 4, 2020

⌛ Testing commit c3e96d1 with merge 8dc3fde...

@bors
Copy link
Contributor

bors commented Mar 4, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 8dc3fde to master...

@bors bors merged commit 8dc3fde into rust-lang:master Mar 4, 2020
@bors bors mentioned this pull request Mar 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flip1995 flip1995 flip1995 approved these changes

+1 more reviewer

@krishna-veerareddy krishna-veerareddy krishna-veerareddy left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

S-waiting-on-bors Status: The marked PR was approved and is only waiting bors

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Detect usage of custom floating-point abs implementation

6 participants

@JarredAllen @JohnTitor @bors @flip1995 @phansch @krishna-veerareddy