Port mitsuhiko's excessive bools lints #5125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil-cow
force-pushed
the
too_many_bools
branch
from
cb22824 to
d06fc2a
Compare
JohnTitor
added
the
S-waiting-on-review
flip1995
reviewed
Feb 2, 2020
flip1995
added
S-waiting-on-author
basil-cow
force-pushed
the
too_many_bools
branch
2 times, most recently
from
e310333 to
bead760
Compare
Contributor
Author
|
fixed, I think |
flip1995
added
S-waiting-on-review
Contributor
|
☔ The latest upstream changes (presumably #5061) made this pull request unmergeable. Please resolve the merge conflicts. |
flip1995
approved these changes
Feb 5, 2020
Member
flip1995
left a comment
flip1995
left a comment
There was a problem hiding this comment.
Thanks! Only 3 NITs and a rebase left to do.
basil-cow
force-pushed
the
too_many_bools
branch
3 times, most recently
from
2586037 to
3901ca7
Compare
flip1995
reviewed
Feb 5, 2020
basil-cow
force-pushed
the
too_many_bools
branch
from
3901ca7 to
338fb7a
Compare
Member
|
@bors r+ |
Contributor
|
📌 Commit 338fb7a has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Feb 5, 2020
Port mitsuhiko's excessive bools lints Closes #4 . changelog: add `struct_excessive_bools` and `fn_params_excessive_bools` lints. I moved is_trait_impl_item check because at first I implemented it as a late pass for some reason but then I realized it's actually an early lint. But it's a useful function to have, should I move it into a separate pr?
Contributor
|
💔 Test failed - checks-travis |
flip1995
added
S-waiting-on-bors
Member
|
@bors retry |
bors
added a commit
that referenced
this pull request
Feb 6, 2020
Port mitsuhiko's excessive bools lints Closes #4 . changelog: add `struct_excessive_bools` and `fn_params_excessive_bools` lints. I moved is_trait_impl_item check because at first I implemented it as a late pass for some reason but then I realized it's actually an early lint. But it's a useful function to have, should I move it into a separate pr?
Contributor
Contributor
|
💔 Test failed - checks-travis |
Member
|
@bors retry |
Contributor
bors
added a commit
that referenced
this pull request
Feb 6, 2020
Port mitsuhiko's excessive bools lints Closes #4 . changelog: add `struct_excessive_bools` and `fn_params_excessive_bools` lints. I moved is_trait_impl_item check because at first I implemented it as a late pass for some reason but then I realized it's actually an early lint. But it's a useful function to have, should I move it into a separate pr?
Contributor
|
☀️ Test successful - checks-travis, status-appveyor |
This was referenced Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4 .
changelog: add
struct_excessive_boolsandfn_params_excessive_boolslints.I moved is_trait_impl_item check because at first I implemented it as a late pass for some reason but then I realized it's actually an early lint. But it's a useful function to have, should I move it into a separate pr?