Omit doc safety/errors header checking for main #5023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phansch
reviewed
Jan 9, 2020
There was a problem hiding this comment.
You could also use utils::is_entrypoint_fn which is a bit more generic and will work for any other other function marked with #[entry].
Also a test would be nice =)
|
I at least made the |
|
Yeah, that test should be enough, thanks! @bors r+ |
|
📌 Commit 2797b64 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 14, 2020
Omit doc safety/errors header checking for main This omits checking `main` methods, which are not usually documented in the way the others are. changelog: none
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This omits checking
mainmethods, which are not usually documented in the way the others are.changelog: none