Skip to content

Rollup of 5 pull requests #4840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Nov 23, 2019
Merged

Rollup of 5 pull requests #4840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
78b7e85
Fix false positive in derive_hash_xor_eq
phansch Nov 1, 2019
8f5b4f3
literal representation restructure 1
Nov 13, 2019
2dbd34f
literal representation restructure 2
Nov 13, 2019
2e8946a
literal representation restructure 3
Nov 13, 2019
2d244d3
literal representation restructure 4
Nov 13, 2019
ec664e8
literal representation restructure 5
Nov 13, 2019
abf62d8
literal representation restructure 6
Nov 13, 2019
b62543f
literal representation restructure 7
Nov 13, 2019
a58b980
literal representation restructure 8
Nov 13, 2019
a9c5a59
literal representation restructure 9
Nov 13, 2019
a8ca8a2
literal representation restructure 10
Nov 13, 2019
eb9caf3
literal representation restructure 11
Nov 13, 2019
2e9d173
literal representation restructure 12
Nov 13, 2019
75e2dcf
literal representation: simplification
Nov 14, 2019
ceb0b2d
literal repr: ignore more warnings in macros
Nov 14, 2019
f2d8197
doc: fix the comment above the lint function
Nov 15, 2019
4da0da9
use more efficient code to generate repeated string
tesuji Nov 19, 2019
d229d91
use usize::from
tesuji Nov 19, 2019
1cba0c9
fix check_infinite_loop by checking for break or return inside loop body
yerke Oct 25, 2019
016857d
Rollup merge of #4730 - yerke:fix-check_infinite_loop, r=flip1995
flip1995 Nov 23, 2019
93d84d7
Rollup merge of #4766 - phansch:fix_fp_in_derive_hash_xor_eq, r=flip1995
flip1995 Nov 23, 2019
623d8c4
Rollup merge of #4811 - mikerite:lit_repr_20191113, r=flip1995
flip1995 Nov 23, 2019
ae69bc4
Rollup merge of #4820 - guanqun:comment-fix, r=flip1995
flip1995 Nov 23, 2019
b452400
Rollup merge of #4830 - lzutao:str-repeat, r=flip1995
flip1995 Nov 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions clippy_lints/src/derive.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ fn check_hash_peq<'a, 'tcx>(
if_chain! {
if match_path(&trait_ref.path, &paths::HASH);
if let Some(peq_trait_def_id) = cx.tcx.lang_items().eq_trait();
if !&trait_ref.trait_def_id().is_local();
then {
// Look for the PartialEq implementations for `ty`
cx.tcx.for_each_relevant_impl(peq_trait_def_id, ty, |impl_id| {
Expand Down
4 changes: 2 additions & 2 deletions clippy_lints/src/excessive_precision.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
use crate::utils::span_lint_and_sugg;
use crate::utils::sugg::format_numeric_literal;
use if_chain::if_chain;
use rustc::hir;
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
Expand Down Expand Up @@ -86,8 +87,7 @@ impl ExcessivePrecision {
if sym_str == s {
None
} else {
let di = super::literal_representation::DigitInfo::new(&s, true);
Some(di.grouping_hint())
Some(format_numeric_literal(&s, None, true))
}
} else {
None
Expand Down
Loading