Skip to content

build: use release build of RTIM #4692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2019
Merged

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Oct 18, 2019

rustup-toolchain-install-master on Travis Windows builds is
unexpectedly slower compared to when run on other OSes.
This commit tries to use release build of RTIM as a mean to
improve performance there.

changelog: none

@tesuji
Copy link
Contributor Author

tesuji commented Oct 18, 2019

The first run seems promising.
The installation time of master toolchain is:

total-time-of-that-step - time-build-RTIM
= 817.11 - (12*60 + 48)
= 49.11 (s)
  • 2nd run: 25.00s
  • 3rd: 26.07s
  • 4th: 27.04s
  • 5th: 27.75s

Compare to old results: 109s, 105.84s

@tesuji

This comment has been minimized.

@tesuji tesuji closed this Oct 18, 2019
@tesuji tesuji reopened this Oct 18, 2019
@tesuji tesuji closed this Oct 18, 2019
@tesuji tesuji reopened this Oct 18, 2019
rustup-toolchain-install-master on Travis Windows builds is
unexpectedly slower when it was running on other OSes.
This commit tries to use release build of RTIM as a mean to
improve performance there.
@tesuji tesuji force-pushed the use-opt-profile-rtim branch from 8b0837f to 7d7451a Compare October 18, 2019 07:58
@tesuji tesuji changed the title [WIP] build: use release build of RTIM build: use release build of RTIM Oct 18, 2019
@tesuji
Copy link
Contributor Author

tesuji commented Oct 18, 2019

Ready for review!

@phansch
Copy link
Member

phansch commented Oct 19, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Oct 19, 2019

📌 Commit 7d7451a has been approved by phansch

bors added a commit that referenced this pull request Oct 19, 2019
build: use release build of RTIM

rustup-toolchain-install-master on Travis Windows builds is
unexpectedly slower compared to when run on other OSes.
This commit tries to use release build of RTIM as a mean to
improve performance there.

changelog: none
@bors
Copy link
Contributor

bors commented Oct 19, 2019

⌛ Testing commit 7d7451a with merge b24ffdd...

@bors
Copy link
Contributor

bors commented Oct 19, 2019

💔 Test failed - checks-travis

@tesuji
Copy link
Contributor Author

tesuji commented Oct 19, 2019

TLS error! @bors retry

@bors
Copy link
Contributor

bors commented Oct 19, 2019

@lzutao: 🔑 Insufficient privileges: not in try users

@flip1995
Copy link
Member

@bors retry

@bors
Copy link
Contributor

bors commented Oct 19, 2019

⌛ Testing commit 7d7451a with merge cbedd97...

bors added a commit that referenced this pull request Oct 19, 2019
build: use release build of RTIM

rustup-toolchain-install-master on Travis Windows builds is
unexpectedly slower compared to when run on other OSes.
This commit tries to use release build of RTIM as a mean to
improve performance there.

changelog: none
@bors
Copy link
Contributor

bors commented Oct 19, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: phansch
Pushing cbedd97 to master...

@bors bors merged commit 7d7451a into rust-lang:master Oct 19, 2019
@tesuji tesuji deleted the use-opt-profile-rtim branch October 19, 2019 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants