useless_attribute: Add unreachable_pub to whitelists #4107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
force-pushed
the
useless_attribute
branch
from
83d5940 to
d7be9c9
Compare
flip1995
approved these changes
May 17, 2019
|
☔ The latest upstream changes (presumably #4110) made this pull request unmergeable. Please resolve the merge conflicts. |
taiki-e
force-pushed
the
useless_attribute
branch
from
d7be9c9 to
40fc725
Compare
|
Rebased. |
|
@bors r=flip1995 |
|
📌 Commit 40fc725 has been approved by |
bors
added a commit
that referenced
this pull request
May 19, 2019
useless_attribute: Add unreachable_pub to whitelists Fixes #4106 changelog: `useless_attribute`: whitelist `unreachable_pub` on `use` items
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4106
changelog:
useless_attribute: whitelistunreachable_pubonuseitems