Properly hash enums #4066
Merged
Properly hash enums #4066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
reviewed
May 7, 2019
| return e.hash(&mut self.s); | ||
| } | ||
|
|
||
| std::mem::discriminant(&e.node).hash(&mut self.s); |
There was a problem hiding this comment.
If we use mem::discriminant we don't need the let c: fn stuff below
|
@bors r+ |
|
📌 Commit b30c6dc has been approved by |
bors
added a commit
that referenced
this pull request
May 8, 2019
Properly hash enums While I wrote this I was saved by a clippy lint... I accidentally fetched the discriminant of a reference to an enum and not of an enum. changelog: reduce hash collisions during clippy-internal hashing
|
💔 Test failed - status-appveyor |
|
☔ The latest upstream changes (presumably #4080) made this pull request unmergeable. Please resolve the merge conflicts. |
flip1995
reviewed
May 14, 2019
| @@ -635,24 +580,15 @@ impl<'a, 'tcx: 'a> SpanlessHash<'a, 'tcx> { | |||
| pub fn hash_stmt(&mut self, b: &Stmt) { | |||
| match b.node { | |||
| StmtKind::Local(ref local) => { | |||
| let c: fn(_) -> _ = StmtKind::Local; | |||
There was a problem hiding this comment.
By removing this, the discriminant needs to be hashed at the beginning of the function. I'll add this.
flip1995
added
the
S-waiting-on-review
|
@bors r=Manishearth |
|
📌 Commit 5dea5d4 has been approved by |
bors
added a commit
that referenced
this pull request
May 14, 2019
Properly hash enums While I wrote this I was saved by a clippy lint... I accidentally fetched the discriminant of a reference to an enum and not of an enum. changelog: reduce hash collisions during clippy-internal hashing
|
Looks like bors did not merge the PR? @bors retry |
bors
added a commit
that referenced
this pull request
May 15, 2019
Properly hash enums While I wrote this I was saved by a clippy lint... I accidentally fetched the discriminant of a reference to an enum and not of an enum. changelog: reduce hash collisions during clippy-internal hashing
|
Bors was redeployed yesterday, maybe timing wasn't good. |
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I wrote this I was saved by a clippy lint... I accidentally fetched the discriminant of a reference to an enum and not of an enum.
changelog: reduce hash collisions during clippy-internal hashing