Move run-pass tests to UI tests #3743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should give us more UI coverage for free. It also removes the `run-pass` suite, so we now only have the `ui` suite.
phansch
force-pushed
the
you_shall_not_pass
branch
from
b736fce to
a586f52
Compare
phansch
added
the
S-waiting-on-review
|
@bors r+ Nice! |
|
📌 Commit a586f52 has been approved by |
bors
added a commit
that referenced
this pull request
Feb 6, 2019
Move run-pass tests to UI tests This should give us more UI coverage for free. It also removes the `run-pass` suite, so we now only have the `ui` suite.
|
☀️ Test successful - checks-travis, status-appveyor |
phansch
added a commit
that referenced
this pull request
Apr 5, 2019
compiletest UI tests do not fail when encountering panics and ICEs unless the `// run-pass` flag is used. (This was forgotten in #3743)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should give us more UI coverage for free.
It also removes the
run-passsuite, so we now only have theuisuite.