Add setup-toolchain.sh script to configure the master version of rustc, #3735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if this is actually correct, but it unblocked me. I stole the logic from .travis.yml, so maybe it should just use this script. |
Manishearth
reviewed
Feb 2, 2019
setup-toolchain.sh
Outdated
| cargo install rustup-toolchain-install-master --debug || echo "rustup-toolchain-install-master already installed" | ||
| RUSTC_HASH=$(git ls-remote https://github.com/rust-lang/rust.git master | awk '{print $1}') | ||
| rustup-toolchain-install-master -f -n master $RUSTC_HASH | ||
| rustup override set master |
|
LGTM, feel free to make travis use it |
jsgf
force-pushed
the
setup-toolchain
branch
3 times, most recently
from
5076b90 to
8a7db0f
Compare
|
Failure should be fixed with #3736, going to retrigger the build |
and update CONTRIBUTING.md accordingly.
|
OK, updated. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and update CONTRIBUTING.md accordingly.