Skip to content

str_split: reduce suggestion diff #16418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ada4a wants to merge 2 commits into
base: master
Choose a base branch
from
Open

str_split: reduce suggestion diff #16418

ada4a wants to merge 2 commits into from
+103 −39

Conversation

@ada4a
Copy link
Contributor

@ada4a ada4a commented Jan 16, 2026

Now, only call_span is replaced, so the receiver is not a part of the
diff. This also removes the need to create a snippet for the receiver.

changelog: [str_split]: reduce suggestion diff

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 16, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 16, 2026

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@ada4a
reduce suggestion diff
3157c0b 
Now, only `call_span` is replaced, so the receiver is not a part of the
diff. This also removes the need to create a snippet for the receiver.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@dswij dswij

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ada4a @rustbot @dswij