Skip to content

Conversation

@profetia
Copy link
Member

@profetia profetia commented Dec 27, 2025

Closes #16298

This lint flags on the type defination, while also giving a warning on the span of the impl block. It is counter-intuitive that you need to put the expect on top of the type defination instead of the impl block to suppress the warning, and this PR addresses that.

changelog: [derive_ord_xor_partial_ord] allow expect on impl block

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 27, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 27, 2025

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

derive_ord_xor_partial_ord lint expectation unfulfilled but also triggered

3 participants