Skip to content

refactor(formatting): split each lint into a separate module #15996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

refactor(formatting): split each lint into a separate module #15996

wants to merge 8 commits into from

Conversation

@ada4a
Copy link
Contributor

@ada4a ada4a commented Oct 31, 2025

changelog: none

Jarcho and others added 8 commits September 24, 2025 12:57
@Jarcho
Rework missing_docs_in_private_items:
6b366ee 
* Don't search spans between items for comments.
* Don't lint items inside bodies, automatically derived impls.
* Don't lint items inside macro generated modules unless they are namable outside.
* Delay `is_from_proc_macro` checks
* Handle reexports when checking if an item is reachable from the crate root.
* Don't lint the crate root.
@Jarcho
Merge and extend tests for missing_docs_in_private_items
2cf2931
@Jarcho
Change HasSession to HasSourceMap
0843df9
@Jarcho
Rename SpanRangeExt to SpanExt
5019aa5
@Jarcho
Rework clippy_utils::source.
dfd4cf7
@Jarcho
Rework the suspicious formatting lints.
851e9fa
@ada4a
move formatting.rs to formatting/mod.rs
c4bbef3
@ada4a
extract each lint to a separate module
ccaee63
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 31, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 31, 2025

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@ada4a
Copy link
Contributor Author

ada4a commented Oct 31, 2025

@rustbot blocked on #12980

@rustbot rustbot added S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Oct 31, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 31, 2025

☔ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts.

@llogiq
Copy link
Contributor

llogiq commented Oct 31, 2025

+6142 lines? Wow, that's not something I'll review in one go.

@ada4a
Copy link
Contributor Author

ada4a commented Oct 31, 2025

It's not as bad as it seems 😅 My part is only the last 2 commits, which should have a much smaller diff -- it's just that @Jarcho refactored formatting, and so I wanted to base my PR on top of that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@llogiq llogiq

Labels

S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ada4a @rustbot @llogiq @Jarcho