Skip to content

Conversation

@ada4a
Copy link
Contributor

@ada4a ada4a commented Oct 29, 2025

Lint names should be in plural

changelog: [empty_drop]: rename to empty_drops

@rustbot rustbot added needs-fcp S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Oct 29, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 29, 2025

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@github-actions
Copy link

Lintcheck changes for 7b9751c

Lint Added Removed Changed
clippy::empty_drop 0 7 0
clippy::empty_drops 7 0 0

This comment will be updated if you push new changes

@samueltardieu
Copy link
Member

Why not discuss this in Zulip and propose to rename all misnamed lints at once? Having some lints renamed and some others suffering from the same problem not renamed is confusing.

@ada4a
Copy link
Contributor Author

ada4a commented Oct 29, 2025

I was thinking that it would be easier to review many smaller PRs than one big one, but yeah your proposal does sound better. Though if we do go with one big PR, I'd really hope that that it would then get merged ASAP, since keeping it up-to-date with master would be a nightmare..

I'll open a thread on Zulip then (though not right away, a bit busy rn)

@llogiq
Copy link
Contributor

llogiq commented Oct 29, 2025

If the discussion is favorable, you may as well extend this PR.

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Oct 29, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 29, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-fcp S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants