Skip to content

Fix derivable_impls suggests wrongly on derive_const #15535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 22, 2025
Merged

Fix derivable_impls suggests wrongly on derive_const #15535

merged 3 commits into from
Aug 22, 2025

Conversation

@profetia
Copy link
Contributor

@profetia profetia commented Aug 22, 2025 •
edited by rustbot
Loading

Closes #15493
Closes #15536

changelog: [derivable_impls] fix wrong suggestions on derive_const

@rustbot
Copy link
Collaborator

rustbot commented Aug 22, 2025

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 22, 2025
samueltardieu
samueltardieu requested changes Aug 22, 2025
View reviewed changes
Copy link
Member

@samueltardieu samueltardieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, some nits to make the code shorter, and an indentation problem.

r? samueltardieu

@rustbot rustbot assigned samueltardieu and unassigned blyxyas Aug 22, 2025
@profetia
Copy link
Contributor Author

profetia commented Aug 22, 2025

Also closes #15536

@github-actions
Copy link

github-actions bot commented Aug 22, 2025 •
edited
Loading

Lintcheck changes for e01cf9b

Lint Added Removed Changed
clippy::derivable_impls 8 0 0

This comment will be updated if you push new changes

@samueltardieu samueltardieu added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Aug 22, 2025
@profetia profetia requested a review from samueltardieu August 22, 2025 22:14
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Aug 22, 2025
@samueltardieu samueltardieu added this pull request to the merge queue Aug 22, 2025
Merged via the queue into rust-lang:master with commit 55286e7 Aug 22, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 22, 2025
@sorairolake sorairolake mentioned this pull request Sep 4, 2025
Closed
@profetia profetia deleted the issue15493 branch September 12, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samueltardieu samueltardieu samueltardieu approved these changes

Assignees

@samueltardieu samueltardieu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

derivable_impls FN when enum is qualified with Self Correct manual impl Default

4 participants

@profetia @rustbot @samueltardieu @blyxyas