bool_comparison: fix incorrect suggestion with >/< and macros
#15513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rustbot
added
the
S-waiting-on-review
ada4a
reviewed
Aug 19, 2025
Contributor
ada4a
left a comment
ada4a
left a comment
There was a problem hiding this comment.
Awesome, thank you! I've got one question, but LGTM otherwise
Contributor
Author
|
You're right. Both of those changes are fine. |
samueltardieu
requested changes
Aug 22, 2025
Member
samueltardieu
left a comment
samueltardieu
left a comment
There was a problem hiding this comment.
Thanks, this LGTM. Could you squash the commits?
r? samueltardieu
This was referenced Aug 22, 2025
notriddle
force-pushed
the
macro-invocation-bool-comparison
branch
from
d2b0da6 to
7697b61
Compare
Contributor
Author
|
Okay, they're squashed. |
samueltardieu
approved these changes
Aug 22, 2025
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15497
changelog: [
bool_comparison]: fix incorrect suggestion with>/<and macros