Skip to content

Split early lints into a new crate #15294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 23 commits into
base: master
Choose a base branch
from
Draft

Split early lints into a new crate #15294

wants to merge 23 commits into from

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Jul 16, 2025 •
edited by rustbot
Loading

Based on #15293

cc @flip1995

changelog: none

Summary Notes

Managed by @rustbot—see help for details

Jarcho added 23 commits July 10, 2025 13:18
@Jarcho
clippy_dev: Move parsing code to it's own module.
e96b926
@Jarcho
clippy_dev parsing changes:
2ffe004 
* Keep results together.
* Keep lints in a map to detect duplicate names.
* Store the crate a lint comes from.
@Jarcho
clippy_dev: Keep a source map when parsing files.
107ab93
@Jarcho
clippy_dev: print parse errors with location info.
7bc7fe5
@Jarcho
clippy_dev: parse lint pass macro calls
ab1f092
@Jarcho
clippy_dev: check that all lints are registered with a lint pass
ca06aa2
@Jarcho
prereqs
eb65729
@Jarcho
Move methods lint pass to a new crate part 1/2
5da633a
@Jarcho
Move methods lint pass to a new crate part 2/2
3dba405
@Jarcho
Move methods lint declarations into sub-modules
87b553a
@Jarcho
Move loops lint pass to a new crate part 1/2
fb03a4e
@Jarcho
Move loops lint pass to a new crate part 2/2
ebf3c4a
@Jarcho
Move loops lint declarations into sub-modules
909d138
@Jarcho
Move matches lint pass to a new crate part 1/2
37a4811
@Jarcho
Move matches lint pass to a new crate part 2/2
4abbb95
@Jarcho
Move matches lint declarations into sub-modules
ebc3934
@Jarcho
Move casts lint pass to a new crate part 1/2
b05963c
@Jarcho
Move casts lint pass to a new crate part 2/2
20ea49c
@Jarcho
Move casts lint declarations to sub-modules
eef9bf6
@Jarcho
Move early lint passes to a new crate part 1/2
9c68561
@Jarcho
Move early lint passes to a new crate part 2/2
c2fbb97
@Jarcho
Move misc_early pass to the early lints crate part 1/2
13edc59
@Jarcho
Move misc_early pass to the early lints crate part 2/2
e8e3abc
@github-actions GitHub Actions
Copy link

Seems that you are trying to add a new lint!

We are currently in a feature freeze, so we are delaying all lint-adding PRs to September 18 and focusing on bugfixes.

Thanks a lot for your contribution, and sorry for the inconvenience.

With ❤ from the Clippy team.

@rustbot note Feature-freeze
@rustbot blocked
@rustbot label +A-lint

@rustbot rustbot added S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work A-lint Area: New lints labels Jul 16, 2025
@Jarcho
Copy link
Contributor Author

Jarcho commented Jul 16, 2025

This is the last I;m going to split for now. As a quick test with incremental disabled I'm getting 10% time reductions on full builds, and 30% if just clippy_lints is changed. This will likely keep improving as more lints get split out.

Testing with incremental disabled since it's never actually been faster for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-lint Area: New lints S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jarcho @rustbot