Skip to content

Fix disallowed_script_idents FP on identifiers with _ #15123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2025

Conversation

profetia
Copy link
Contributor

@profetia profetia commented Jun 24, 2025

Closes #15116

The cause for this issue is that _ belongs to the Common catagory in unicode instead of Latin like other ASCII alphabets. Since ASCII characters are always allowed, I just added an extra is_ascii() check to ensure this.

changelog: [disallowed_script_idents] fix FP on identifiers with _

@rustbot
Copy link
Collaborator

rustbot commented Jun 24, 2025

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 24, 2025
@dswij dswij added this pull request to the merge queue Jun 28, 2025
Merged via the queue into rust-lang:master with commit 428208e Jun 28, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clippy::disallowed_script_idents has false positive if there is an _ underscore in the ident
3 participants