Skip to content

handle another type of collapsible if-statement #15104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

handle another type of collapsible if-statement #15104

wants to merge 2 commits into from
+178 −5

Conversation

Arc8ne
Copy link

@Arc8ne Arc8ne commented Jun 22, 2025

fixes #812

changelog: [collapsible_if]: handle another type of collapsible if-statement

@rustbot
Copy link
Collaborator

rustbot commented Jun 22, 2025

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 22, 2025
@Arc8ne
Copy link
Author

Arc8ne commented Jun 22, 2025 •
edited
Loading

r? @samueltardieu

This PR is an updated version of PR #15027.

@rustbot rustbot assigned samueltardieu and unassigned dswij Jun 22, 2025
samueltardieu
samueltardieu requested changes Jun 23, 2025
View reviewed changes
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jun 23, 2025
@Arc8ne
Remove an unnecessary comment that was accidentally introduced by the…
8b9f3ee 
… previous commit.

Correct specifying of applicability for calls to functions that modify an `Applicability`.
Update suggestion message to adhere to standard conventions.
Change default value passed to `Sugg::hir_with_applicability` to a suitable one.
Format code.
Update the corresponding `stderr` file for this lint.
@Arc8ne Arc8ne requested a review from samueltardieu June 23, 2025 14:19
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Jun 23, 2025
@Arc8ne
Copy link
Author

Arc8ne commented Jun 24, 2025 •
edited
Loading

@samueltardieu Thanks for the review, I have implemented your suggested changes in my latest commit and was wondering if you could re-review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueltardieu samueltardieu Awaiting requested review from samueltardieu

Requested changes must be addressed to merge this pull request.

Assignees

@samueltardieu samueltardieu

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

improve collapsible if in complex cases with same expressions
4 participants
@Arc8ne @rustbot @samueltardieu @dswij