Skip to content

fixes #14869 #15100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fixes #14869 #15100

wants to merge 3 commits into from

Conversation

honeyspoon
Copy link

@honeyspoon honeyspoon commented Jun 22, 2025

fixes #14869

changelog: stop triggering similar_names for 3-character names

Added a simple check if both chars are of length 3
If they are, we skip the check for that pair.

This won't handle the 4 v 3 case.
Not sure if this was the intent of the issue.

Also saw we have some hardcoded exemptions for set, get and lhs, rhs
Tried removing them thinking they would be handled by the new condition.
But we have to keep because they allow for bla_lhs v bla_rhs to be skipped

@rustbot
Copy link
Collaborator

rustbot commented Jun 22, 2025

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop triggering similar_names for 3-character names
3 participants