New lint: missing_workspace_lints
#15092
Open
+181
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @samueltardieu. Use |
rustbot
added
the
S-waiting-on-review
BenjaminBrienen
force-pushed
the
unused-workspace-lints
branch
3 times, most recently
from
1e4b341 to
9ecf6da
Compare
BenjaminBrienen
force-pushed
the
unused-workspace-lints
branch
from
9ecf6da to
9d20899
Compare
|
I think this should be a Cargo lint instead. "lints" are probably not the only key which should be checked, for example |
r? @llogiq |
|
Clippy already has a few cargo lints and I think it even checks for missing basic metadata (allow by default). If they get moved into cargo itself, this could move with them? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new lint for when your workspace has a lint configuration table, but a member of the workspace implicitly does not inherit that configuration. This has bitten me in the butt many times in my large workspace with many crates where I forget to add
lints.workspace = true.Example in rust-analyzer!
Worked on with @NateD-MSFT during the RustWeek workshop.
changelog: [
missing_workspace_lints]: Added new lint to warn when a project is in a workspace with workspace lint configuration, but has not explicitly configuredlints.workspace.