or_fun_call: lint method calls inside map_or first arg #15074

klensy · 2025-06-18T10:09:15Z

blocked on #15073

Lint method calls inside map_or too, so for this, lint will be showed:

Some(4).map_or("asd".to_string().len() as i32, f);

previously it worked only for:

Some(4).map_or(slow_fun(), f);

Sorry for multiple or_fun_call PRs.

changelog: [or_fun_call]: lint method calls inside map_or first arg

klensy · 2025-06-22T09:56:00Z

Okay, review last 3 commits please and I'll rebase this pr or #15073, depending on who will be first.

rustbot · 2025-06-22T09:56:05Z

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

klensy added 2 commits June 21, 2025 12:42

precommit test

dc3b8be

or_fun_call: lint Option/Result::and(_then) too

a82c142

klensy force-pushed the or-fun-call-more branch from fcce1e4 to 85eed3d Compare June 21, 2025 09:50

klensy added 3 commits June 21, 2025 12:57

precommit test

7320c2a

also lint method calls inside map_or first arg

55b107a

dogfood: fix few lint issues

af7625a

klensy force-pushed the or-fun-call-more branch from 85eed3d to af7625a Compare June 21, 2025 09:57

klensy marked this pull request as ready for review June 22, 2025 09:56

rustbot assigned llogiq Jun 22, 2025

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 22, 2025

Provide feedback