Soft rename clippy::all to clippy::default#14689
Soft rename clippy::all to clippy::default#14689Alexendoo wants to merge 1 commit intorust-lang:masterfrom
clippy::all to clippy::default#14689Conversation
rustbot
added
the
S-waiting-on-review
| @@ -0,0 +1,11 @@ | |||
| // Tests that `clippy::all` still works without a deprecation warning | |||
There was a problem hiding this comment.
Sorry to intrude, but why don't you want a deprecation warning?
There was a problem hiding this comment.
It's starting as a soft deprecation since it's very widely used, it may eventually become a warning
There was a problem hiding this comment.
I would not deprecate it. I don't think it is ever worth to do so. I think clippy::all is older than 5 years by now. It will take at least the same amount of time until clippy::default is used in more places than clippy::all, I would think. So maybe really really long-term, we can deprecate it. But that might even be the decision of a different set of people by then.
Plus, I don't see any downsides in keeping it.
flip1995
left a comment
flip1995
left a comment
There was a problem hiding this comment.
Nice!
Giving @rust-lang/clippy @rust-lang/clippy-contributors until the end of the week to still raise concerns (as there's no going back realistically). But I think everyone is on-board with this.
This comment has been minimized.
This comment has been minimized.
|
Ping @Alexendoo this needs a rebase. I don't think any objections were raised. |
Alexendoo
force-pushed
the
clippy-default
branch
from
0a70aea to
a033f84
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
Lintcheck changes for a033f84
This comment will be updated if you push new changes |
Alexendoo
added
S-blocked
Provide all lint group names to Clippy Unblocks rust-lang/rust-clippy#14689
Provide all lint group names to Clippy Unblocks rust-lang/rust-clippy#14689
Provide all lint group names to Clippy Unblocks rust-lang/rust-clippy#14689
Provide all lint group names to Clippy Unblocks rust-lang/rust-clippy#14689
Provide all lint group names to Clippy Unblocks rust-lang/rust-clippy#14689
Provide all lint group names to Clippy Unblocks rust-lang/rust-clippy#14689
Provide all lint group names to Clippy Unblocks rust-lang/rust-clippy#14689
Rollup merge of #152625 - Alexendoo:lint-group-names, r=Kivooeo Provide all lint group names to Clippy Unblocks rust-lang/rust-clippy#14689
There was a problem hiding this comment.
Just saw a r-l/r PR related to this, which made me realize that we never merged this. Sorry, I completely dropped the ball here.
LGTM. I'll let triagebot reassign someone else from the Clippy team. If there is no further comment on this, feel free to merge it.
|
r? clippy |
Alexendoo
removed
the
S-blocked
|
No worries, it was sat blocked waiting for me to make that PR I thought I read somewhere that GitHub no longer spammed threads if you linked it in a commit, I guess that was not the case 😅 |
Provide all lint group names to Clippy Unblocks rust-lang#14689
6 participants
r? @flip1995
For now I haven't updated the docs since people read the current README/etc for stable usage
changelog:
clippy::allhas been renamed toclippy::default, existing uses ofclippy::alldo not need to be changed