Skip to content

style: pull one more if into the let-chain #14669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

style: pull one more if into the let-chain #14669

merged 1 commit into from
Apr 23, 2025

Conversation

ada4a
Copy link
Contributor

@ada4a ada4a commented Apr 22, 2025

cargo dev fmt seems to not work for some reason (possibly because of all the comments in the let-chain), so I formatted it manually -- I hope it's right

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Apr 22, 2025

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 22, 2025
@Jarcho
Copy link
Contributor

Jarcho commented Apr 22, 2025

rustfmt doesn't handle comments within binary operator chains.

@ada4a
Copy link
Contributor Author

ada4a commented Apr 22, 2025

rustfmt doesn't handle comments within binary operator chains.

"doesn't handle" as in "fails to work when they are present", right?

@Jarcho
Copy link
Contributor

Jarcho commented Apr 22, 2025

The whole expression containing them doesn't get formatted.

y21
y21 approved these changes Apr 23, 2025
View reviewed changes
Copy link
Member

@y21 y21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! Hide whitespace is very useful for looking at PR diffs like this

@y21 y21 added this pull request to the merge queue Apr 23, 2025
Merged via the queue into rust-lang:master with commit 34f81f9 Apr 23, 2025
11 checks passed
@ada4a ada4a deleted the style branch April 30, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y21 y21 y21 approved these changes

Assignees

@y21 y21

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ada4a @rustbot @Jarcho @y21