Skip to content

Refactor and speed up cargo dev fmt #14638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 17, 2025
Merged

Refactor and speed up cargo dev fmt #14638

merged 2 commits into from
May 17, 2025

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Apr 17, 2025 •
edited by rustbot
Loading

Based on #14616

cargo dev fmt should now run almost instantly rather than taking a few seconds.

changelog: None

@rustbot
Copy link
Collaborator

rustbot commented Apr 17, 2025

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 17, 2025
@rustbot

This comment has been minimized.

Sign in to view
@Jarcho Jarcho force-pushed the dev_fmt branch 2 times, most recently from b855b48 to 685ad6e Compare April 17, 2025 09:56
@Alexendoo Alexendoo added S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Apr 18, 2025
@samueltardieu
Copy link
Contributor

I find it ironical that the CI fails on cargo dev fmt --check!

@rustbot

This comment has been minimized.

Sign in to view
@Jarcho Jarcho force-pushed the dev_fmt branch 2 times, most recently from 3e74c27 to 1fe1000 Compare May 17, 2025 08:27
@Jarcho Jarcho force-pushed the dev_fmt branch 3 times, most recently from e45cc01 to 2979711 Compare May 17, 2025 08:45
@samueltardieu
Copy link
Contributor

Assigning to myself as I've been reviewing and testing some iterations of this PR already.

r? @samueltardieu

@rustbot rustbot assigned samueltardieu and unassigned Alexendoo May 17, 2025
@samueltardieu samueltardieu enabled auto-merge May 17, 2025 10:11
@samueltardieu samueltardieu added this pull request to the merge queue May 17, 2025
Merged via the queue into rust-lang:master with commit 9ebfb84 May 17, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@samueltardieu samueltardieu

Labels
S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jarcho @rustbot @samueltardieu @Alexendoo