Extend precedence for bitmasking and shift
#13743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog: extended [`precedence`] to lint for bitmasking and bit shifting without parentheses
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Jarcho (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
the
S-waiting-on-review
…a different result
tgross35
added a commit
to tgross35/rust-libm
that referenced
this pull request
Dec 27, 2024
[1] extends Clippy's `precedence` lint to cover `&`, `|`, and bitshifts. Update cases that are flagged by this in the most recent nightly. [1]: rust-lang/rust-clippy#13743
gsson
pushed a commit
to gsson/scylla-rust-driver
that referenced
this pull request
Feb 22, 2025
gsson
pushed a commit
to gsson/scylla-rust-driver
that referenced
this pull request
Feb 22, 2025
Introduced by rust-lang/rust-clippy#13743 I have not benchmarked this change, but code generation seems better, see comparison in https://godbolt.org/z/j78fETzbT
8 tasks
tgross35
added a commit
to rust-lang/libm
that referenced
this pull request
Apr 18, 2025
[1] extends Clippy's `precedence` lint to cover `&`, `|`, and bitshifts. Update cases that are flagged by this in the most recent nightly. [1]: rust-lang/rust-clippy#13743
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Jun 3, 2025
[1] extends Clippy's `precedence` lint to cover `&`, `|`, and bitshifts. Update cases that are flagged by this in the most recent nightly. [1]: rust-lang/rust-clippy#13743
tautschnig
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Jun 17, 2025
[1] extends Clippy's `precedence` lint to cover `&`, `|`, and bitshifts. Update cases that are flagged by this in the most recent nightly. [1]: rust-lang/rust-clippy#13743
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we can lint for the expressions like
_&_>>_,_<<_^_, etc. And will suggest to add parentheses like_&(_>>_)and(_<<_)^_.I get implementation suggestions from #8735 (review).
changelog: extended [
precedence] to lint for bit masking and bit shifting without parenthesesfixes #6632