[infinite_loops]: fix incorrect suggestions on async functions/closures
#13608
+95
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Alexendoo rustbot has assigned @Alexendoo. Use |
rustbot
added
the
S-waiting-on-review
J-ZhengLi
changed the title
infinite_loops]: fix suggestion error on async functions/closuresinfinite_loops]: fix incorrect suggestions on async functions/closures
J-ZhengLi
force-pushed
the
issue12338-new
branch
from
7d0d282 to
c4815ae
Compare
hamirmahal
suggested changes
Oct 26, 2024
|
|
||
| /// Return `true` if the given [`FnRetTy`] is never (!). | ||
| /// | ||
| /// Note: This function also take care of return type of async fn, |
There was a problem hiding this comment.
Suggested change
| /// Note: This function also take care of return type of async fn, | |
| /// Note: This function also takes care of the return type of async fn, |
Alexendoo
approved these changes
Nov 1, 2024
|
Thanks! Async fns strike again 👀 @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #12338
I intend to fix this in #12421 but got distracted by some other problems in the same lint, delaying the process of closing the actual issue. So here's a separated PR that only focus on the issue and nothing else.
changelog: [
infinite_loops]: fix suggestion error on async functions/closures