Skip to content

Fix large_stack_arrays triggering when nesting const items #13534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

GnomedDev
Copy link
Contributor

Fixes #13529.

r? @flip1995

changelog: [large_stack_arrays]: No longer triggers in static/const context when using nested items

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 10, 2024
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix!

@flip1995
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 11, 2024

📌 Commit 87b4c1f has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 11, 2024

⌛ Testing commit 87b4c1f with merge 05f3793...

@bors
Copy link
Contributor

bors commented Oct 11, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 05f3793 to master...

@bors bors merged commit 05f3793 into rust-lang:master Oct 11, 2024
8 checks passed
@GnomedDev GnomedDev deleted the fix-large-stack-arrays-nested-item branch October 11, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

large_stack_arrays still lint on nested const items
5 participants