Skip to content

Split def_path_res into two parts #13431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Conversation

GnomedDev
Copy link
Contributor

def_path_res previously had two jobs:

  1. looking up the crates to find the path in
  2. looking up path in said crates

This splits that job up into two functions, keeping def_path_res as an adapter between the both, to avoid repeating the first step when repeatedly looking up items in the same crate.

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Sep 21, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @y21 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 21, 2024
@bors
Copy link
Contributor

bors commented Sep 22, 2024

☔ The latest upstream changes (presumably #13440) made this pull request unmergeable. Please resolve the merge conflicts.

@y21
Copy link
Member

y21 commented Sep 23, 2024

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Sep 23, 2024

📌 Commit 6b34c8d has been approved by y21

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 23, 2024

⌛ Testing commit 6b34c8d with merge 8ab744e...

@bors
Copy link
Contributor

bors commented Sep 23, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: y21
Pushing 8ab744e to master...

@bors bors merged commit 8ab744e into rust-lang:master Sep 23, 2024
8 checks passed
@GnomedDev GnomedDev deleted the split-def_path_res branch September 24, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants