Skip to content

Conversation

@c410-f3r
Copy link
Contributor

@c410-f3r c410-f3r commented Sep 11, 2024

Fix #13381

Makes missing_panics_doc act like other "panicking" lints (unwrap_used, panic, etc) in constant environments.

changelog: Ignore missing_panics_doc in constant environments

@rustbot
Copy link
Collaborator

rustbot commented Sep 11, 2024

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 11, 2024
@c410-f3r
Copy link
Contributor Author

r? clippy

@rustbot rustbot assigned y21 and unassigned dswij Sep 17, 2024
@y21
Copy link
Member

y21 commented Sep 17, 2024

Looks good, thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Sep 17, 2024

📌 Commit 0905a77 has been approved by y21

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 17, 2024

⌛ Testing commit 0905a77 with merge 903293b...

@bors
Copy link
Contributor

bors commented Sep 17, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: y21
Pushing 903293b to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Sep 17, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: y21
Pushing 903293b to master...

@bors bors merged commit 903293b into rust-lang:master Sep 17, 2024
@bors
Copy link
Contributor

bors commented Sep 17, 2024

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

github-merge-queue bot pushed a commit that referenced this pull request Jun 29, 2025
…ly contexts (#15170)

changelog: [`missing_panics_doc`]: Allow unwrap() and expect()s in
const-only contexts

Fixes #15169.

As far as I can tell, this change keeps this lint in line with similar
issues and their fixes such as
#13382 and
#10240, so I feel pretty confident that the
behavior it exhibits after this PR is correct.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

panic_in_result_fn shouldn't trigger in constant environments

5 participants