Skip to content

Fix broken list for lints config #13177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2024
Merged

Fix broken list for lints config #13177

merged 1 commit into from
Jul 31, 2024

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Jul 29, 2024 •
edited by xFrednet
Loading

Follow-up of #13166.

Finally figured out that it was a transformation and not the source that was the problem. It now looks like this:

Screenshot from 2024-07-29 16-29-10

r? @xFrednet

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 29, 2024
@GuillaumeGomez
Copy link
Member Author

This one is a bugfix so let's see if we can it in faster.

r? @Alexendoo

@rustbot rustbot assigned Alexendoo and unassigned xFrednet Jul 30, 2024
@xFrednet
Copy link
Member

I'm looking at it rn :D

r? @xFrednet

@rustbot rustbot assigned xFrednet and unassigned Alexendoo Jul 31, 2024
@xFrednet
Copy link
Member

Works perfectly! Thanks for finding the bug :D

Roses are red,
    Indention is fixed,
Options now render,
    With common prefix

@bors
Copy link
Contributor

bors commented Jul 31, 2024

📌 Commit 712e8f4 has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 31, 2024

⌛ Testing commit 712e8f4 with merge ea06fa3...

@bors
Copy link
Contributor

bors commented Jul 31, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing ea06fa3 to master...

@bors bors merged commit ea06fa3 into rust-lang:master Jul 31, 2024
8 checks passed
@GuillaumeGomez GuillaumeGomez deleted the fix-broken-list-lints-config branch July 31, 2024 11:42
@GuillaumeGomez
Copy link
Member Author

Thanks a lot! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xFrednet xFrednet xFrednet approved these changes

Assignees

@xFrednet xFrednet

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillaumeGomez @xFrednet @bors @Alexendoo @rustbot