Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nightly version -> 2024-06-17 #12952

Closed
wants to merge 2 commits into from

Conversation

tgross35
Copy link
Contributor

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Jun 18, 2024

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 18, 2024
@tgross35
Copy link
Contributor Author

My Rust PR rust-lang/rust#126608 requires me fixing the Clippy ICEs in #12950, but that PR ideally needs some changes to const eval that only landed a couple of days ago. So I am just hoping that I can get this and #12950 in before the next subtree sync, rather than needing to wait for two syncs to finish rust-lang/rust#126608 :)

r? @flip1995 since I think you usually handle the syncs

@rustbot rustbot assigned flip1995 and unassigned Alexendoo Jun 18, 2024
@flip1995
Copy link
Member

flip1995 commented Jun 18, 2024

My recommendation is, to apply the changes in #12950 in your Rust PR. The Clippy team will then get pinged. I skimmed those changes and they all LGTM.

To do this easily: In your f16-f128-fixme branch in the Clippy repo run:

git diff --patch master > f16-f128-fixme.patch  # assumes that `master` is the merge base of your PR

And then in the Rust repo (ideally with a clean checkout of your f16-f128-library branch) run:

git apply /path/to/rust-clippy/f16-f128-fixme.patch

Can the FIXMEs noting that tests should be added be resolved with your Rust PR?

@tgross35
Copy link
Contributor Author

That would be great, thanks for the suggestion. I combined this toolchain bump into #12950 to make sure CI is green before doing that.

Can the FIXMEs noting that tests should be added be resolved with your Rust PR?

Unfortunately not yet - I'm in a bit of a vicious cycle where I can't add the needed const casting tests without some of those constants and the functions that depend on them, can't add the constants because they cause the Clippy ICE, and can't fully update these Clippy tests since I don't have const casting. So the casting fix and Clippy test fixes should come soon, just not until after that PR.

@tgross35 tgross35 closed this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants