Bump nightly version -> 2024-06-17 - #12952
Conversation
|
r? @Alexendoo rustbot has assigned @Alexendoo. Use |
|
My Rust PR rust-lang/rust#126608 requires me fixing the Clippy ICEs in #12950, but that PR ideally needs some changes to const eval that only landed a couple of days ago. So I am just hoping that I can get this and #12950 in before the next subtree sync, rather than needing to wait for two syncs to finish rust-lang/rust#126608 :) r? @flip1995 since I think you usually handle the syncs |
|
My recommendation is, to apply the changes in #12950 in your Rust PR. The Clippy team will then get pinged. I skimmed those changes and they all LGTM. To do this easily: In your git diff --patch master > f16-f128-fixme.patch # assumes that `master` is the merge base of your PRAnd then in the Rust repo (ideally with a clean checkout of your git apply /path/to/rust-clippy/f16-f128-fixme.patchCan the |
|
That would be great, thanks for the suggestion. I combined this toolchain bump into #12950 to make sure CI is green before doing that.
Unfortunately not yet - I'm in a bit of a vicious cycle where I can't add the needed const casting tests without some of those constants and the functions that depend on them, can't add the constants because they cause the Clippy ICE, and can't fully update these Clippy tests since I don't have const casting. So the casting fix and Clippy test fixes should come soon, just not until after that PR. |
changelog: none