Skip to content

[WIP] fix [unnecessary_cast] ignoring lifetime differences #12869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

J-ZhengLi
Copy link
Member

fixes: #12860


changelog: fix [unnecessary_cast] FP with lifetime differences

@rustbot
Copy link
Collaborator

rustbot commented May 30, 2024

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@J-ZhengLi J-ZhengLi marked this pull request as draft May 30, 2024 10:52
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 30, 2024
@J-ZhengLi J-ZhengLi added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels May 30, 2024
With attempt to get expr's hir_ty.
@bors
Copy link
Contributor

bors commented Jun 7, 2024

☔ The latest upstream changes (presumably #12897) made this pull request unmergeable. Please resolve the merge conflicts.

@J-ZhengLi J-ZhengLi closed this Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unnecessary_cast false positive when casting pointers to types with lifetime parameters
4 participants