-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Fix: no_effect_underscore_binding fires on ignored parameters of async fns #12323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @y21 (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to clippy!
The changes look good to me, but, while we're here, can you update the lint description to remove the "known problems" section, since this is outdated?
rust-clippy/clippy_lints/src/no_effect.rs
Lines 46 to 48 in 6aa5f1a
/// ### Known problems | |
/// Further usage of this variable is not checked, which can lead to false positives if it is | |
/// used later in the code. |
#12172 started checking for usage
Deleted "Known problems" section. |
Thanks! Could you squash the first 3 commits? Then it's good to merge. |
---- UPDATE: add async block into test. FIX: no_effect Fixed asynchronous function parameter names with underscores so that warnings are not displayed when underscores are added to parameter names ADD: test case
The `Known problems` section was removed because it is old information.
Sorry for the confusion, but he is my alter ego, so no problem. Also, I squashed 3 commits, please check them. |
Nice, thank you! @bors r+ |
Fix: no_effect_underscore_binding fires on ignored parameters of async fns Fixes #12279 changelog: Fix [`no_effect_underscore_binding`]) The warning is no longer displayed when an underscore is given in the parameter name of an asynchronous function.
💔 Test failed - checks-action_test |
@bors retry |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Fixes #12279
changelog: Fix [
no_effect_underscore_binding
])The warning is no longer displayed when an underscore is given in the parameter name of an asynchronous function.