Disable vec_box when using different allocators - #11780
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @xFrednet (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
xFrednet
left a comment
There was a problem hiding this comment.
Welcome to Clippy 👋. The changes look good to me, there is one small additional tests I would like to see and then we can merge this :D
|
Looks good to me, thank you for the swift update :D @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Fixes #7114
This PR disables the
vec_boxlint when theBoxandVecuse different allocators (but not when they use the same - custom - allocator).For example -
Vec<Box<i32, DummyAllocator>>will disable the lint, andVec<Box<i32, DummyAllocator>, DummyAllocator>will not disable the lint.In addition, the applicability of this lint has been changed to
Unspecifieddue to the automatic fixes potentially breaking code such as the following:It should be noted that the
if_chain->let-chainsfix has also been applied to this lint, so the diff does contain many changes.changelog: disable
vec_boxlint when using nonstandard allocators