Skip to content

Conversation

@mrnossiom
Copy link
Contributor

Fixes: #11181

changelog: [ptr_arg]: ignore extern functions that are not

I am not sure whether we should ignore other Rust calling conventions like rust-intrinsic, rust-call or rust-cold.

@rustbot
Copy link
Collaborator

rustbot commented Jul 23, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Jarcho (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 23, 2023
@Jarcho
Copy link
Contributor

Jarcho commented Jul 23, 2023

The call to check_mut_from_ref should happen before before the ABI check. mut_from_ref shouldn't depend on the function's ABI.

@Jarcho
Copy link
Contributor

Jarcho commented Jul 24, 2023

Thank you. @bors r+

@bors
Copy link
Contributor

bors commented Jul 24, 2023

📌 Commit 7b8598d has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 24, 2023

⌛ Testing commit 7b8598d with merge a447725...

@bors
Copy link
Contributor

bors commented Jul 24, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing a447725 to master...

@bors bors merged commit a447725 into rust-lang:master Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ptr_arg should ignore extern functions

4 participants