Skip to content

Update dependencies cargo_metadata and clap #10270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Update dependencies cargo_metadata and clap #10270

merged 1 commit into from
Feb 1, 2023

Conversation

kadiwa4
Copy link
Contributor

@kadiwa4 kadiwa4 commented Jan 31, 2023

changelog: none

Allows removing some duplicate dependencies in rust-lang/rust's Cargo.lock.

@rustbot
Copy link
Collaborator

rustbot commented Jan 31, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @flip1995 (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 31, 2023
@flip1995
Copy link
Member

flip1995 commented Feb 1, 2023

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Feb 1, 2023

📌 Commit ef25961 has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Feb 1, 2023

⌛ Testing commit ef25961 with merge 588c1ba...

@bors
Copy link
Contributor

bors commented Feb 1, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 588c1ba to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Feb 1, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 588c1ba to master...

@bors bors merged commit 588c1ba into rust-lang:master Feb 1, 2023
@kadiwa4 kadiwa4 deleted the update_some_deps branch February 1, 2023 16:57
flip1995 added a commit to flip1995/rust-clippy that referenced this pull request Feb 10, 2023
Clap was updated in rust-lang#10270, which broke the command
line of clippy_dev. This swaps out contains_id, which now returns always
true in the places it was used with get_flag.
@flip1995 flip1995 mentioned this pull request Feb 10, 2023
flip1995 added a commit to flip1995/rust-clippy that referenced this pull request Feb 10, 2023
Clap was updated in rust-lang#10270, which broke the command
line of clippy_dev. This swaps out contains_id, which now returns always
true in the places it was used with get_flag.
bors added a commit that referenced this pull request Feb 10, 2023
Fix CLI of clippy_dev

Clap was updated in #10270, which broke the command line of clippy_dev. This swaps out contains_id, which now returns always true in the places it was used with get_flag.

r? `@xFrednet`

This should also fix https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/.60cargo.20dev.20setup.20intellij.60.20is.20degraded/near/325770850

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants