-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Document lint configuration values in Clippy's book #10199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document lint configuration values in Clippy's book #10199
Conversation
Signed-off-by: Tyler Weaver <maybe@tylerjw.dev>
8ac8ffe
to
d43dce1
Compare
To note, the reason for removing a reference to |
b6c67e9
to
1edac66
Compare
@xFrednet I believe I'm ready for a first review. Ok, now I am, fixed up the tests. |
Signed-off-by: Tyler Weaver <maybe@tylerjw.dev>
1edac66
to
2e2ae68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A solid start, thank you for the work! I've added some comments, and also gave some feedback about the table/format in the issue. I like the look of the table, but this might be a case where a different format is sadly more functional.
I updated this to produce both a table and paragraph sections. The table portion looks like this: And then if you were to click on any of those configs it would go to a table section that looks like this: I tried making the table widths work for the names, default values, and lints but couldn't get it to look good, so I moved the lints into the paragraphs and made the table just the config names and their default values. Clicking on any one goes to the paragraph, which now includes not only the list of lints but also the config type and the whole doc string. |
0bc745d
to
ce75ce8
Compare
Signed-off-by: Tyler Weaver <maybe@tylerjw.dev>
ce75ce8
to
7d1609d
Compare
@xFrednet this is ready for another review. I made some changes to how the generated doc output. Let me know if you have any ideas for how I could format it better and other things you notice that I could improve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version looks good to me! I have two more required adjustments, and then we can merge this.
- Is the comment for the CI changes
- Could you also update the add configuration to a lint section to have a 5th step, to run
cargo collect-metadata
?
Then this should be ready! Thank you very much for this update!!!!
@xFrednet I pushed the two changes you laid out. Thank you for going and figuring out the github actions magic I needed for this. |
Everything looks perfect to me! Thank you very much. This is a very nice step forward for Clippy's configuration! @bors r+ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Awesome! Thanks for implementing this :) @xFrednet Sorry for not replying to your CI question. But the solution you came up with is perfect 👍 |
@flip1995 No problem at all, I would have waited if Google didn't turn up such a simple solution. :) |
changelog: document lint configuration values in Clippy's book
fixes #9991
r? @xFrednet