ICE: Failed to normalize <std::option::Option<&std::option::Option<usize>> as std::iter::Iterator>::Item

[irevoire]

Hello, we encounter a ICE with Clippy in our CI.
I can't reproduce the error locally though.
You can look at it here: https://github.com/meilisearch/meilisearch/runs/5883955221?check_suite_focus=true
Hope that helps!

[fasterthanlime]

Seeing this in our CI too - ours is a proprietary codebase so I can't share the code, but here's the full error:

cargo clippy --all-targets

    Checking fly-proxy v0.1.0 (/home/amos/work/fly-proxy/crates/fly-proxy)
error: internal compiler error: compiler/rustc_middle/src/ty/normalize_erasing_regions.rs:179:90: Failed to normalize > as std::iter::Iterator>::Item, maybe try to call `try_normalize_erasing_regions` instead

thread 'rustc' panicked at 'Box', compiler/rustc_errors/src/lib.rs:1160:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust-clippy/issues/new

note: Clippy version: clippy 0.1.60 (7737e0b 2022-04-04)

query stack during panic:
#0 [analysis] running analysis passes on this crate
end of query stack
thread 'rustc' panicked at 'Box', compiler/rustc_errors/src/lib.rs:1160:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust-clippy/issues/new

note: Clippy version: clippy 0.1.60 (7737e0b 2022-04-04)

query stack during panic:
#0 [analysis] running analysis passes on this crate
end of query stack
error: could not compile `fly-proxy`
warning: build failed, waiting for other jobs to finish...
error: build failed
error: Recipe `check` failed on line 15 with exit code 101

This happens on 1.60, didn't happen on 1.59.

[Jarcho]

I think this was fixed with #8602. Can you check once 2022-04-08 is available?

[fasterthanlime]

Still seeing a similar error with 2022-04-08:

click for surprise ICE

error: internal compiler error: compiler/rustc_middle/src/ty/normalize_erasing_regions.rs:179:90: Failed to normalize > as std::iter::Iterator>::Item, maybe try to call `try_normalize_erasing_regions` instead
thread 'rustc' panicked at 'Box', /rustc/e745b4ddbd05026c75aae4506aef39fdfe1603c5/compiler/rustc_errors/src/lib.rs:1349:9

note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
note: the compiler unexpectedly panicked. this is a bug.
note: we would appreciate a bug report: https://github.com/rust-lang/rust-clippy/issues/new
note: Clippy version: clippy 0.1.61 (e745b4d 2022-04-07)
query stack during panic:

#0 [analysis] running analysis passes on this crate

end of query stack

warning: fly-proxy (lib) generated 1 warning

error: could not compile fly-proxy; 1 warning emitted

full backtrace (RUST_BACKTRACE=1)

thread 'rustc' panicked at 'Box', /rustc/e745b4ddbd05026c75aae4506aef39fdfe1603c5/compiler/rustc_errors/src/lib.rs:1349:9
stack backtrace:
   0: std::panicking::begin_panic::
   1: std::panic::panic_any::
   2: ::bug::<&alloc::string::String>
   3: ::bug::<&alloc::string::String>
   4: rustc_middle::ty::context::tls::with_opt::::{closure#0}, ()>
   5: rustc_middle::util::bug::opt_span_bug_fmt::
   6: rustc_middle::util::bug::bug_fmt
   7: ::fold_ty
   8: clippy_utils::ty::get_associated_type
   9: clippy_lints::methods::iter_overeager_cloned::check
  10: ::check_expr
  11: ::check_expr
  12:  as rustc_hir::intravisit::Visitor>::visit_expr
  13: rustc_hir::intravisit::walk_expr::>
  14:  as rustc_hir::intravisit::Visitor>::visit_expr
  15:  as rustc_hir::intravisit::Visitor>::visit_block
  16:  as rustc_hir::intravisit::Visitor>::visit_expr
  17:  as rustc_hir::intravisit::Visitor>::visit_nested_body
  18:  as rustc_hir::intravisit::Visitor>::visit_fn
  19: rustc_hir::intravisit::walk_impl_item::>
  20:  as rustc_hir::intravisit::Visitor>::visit_nested_impl_item
  21: rustc_hir::intravisit::walk_impl_item_ref::>
  22: rustc_hir::intravisit::walk_item::>
  23:  as rustc_hir::intravisit::Visitor>::visit_nested_item
  24: rustc_hir::intravisit::walk_mod::>
  25:  as rustc_hir::intravisit::Visitor>::visit_mod
  26:  as rustc_hir::intravisit::Visitor>::visit_nested_item
  27: rustc_hir::intravisit::walk_mod::>
  28:  as rustc_hir::intravisit::Visitor>::visit_mod
  29:  as rustc_hir::intravisit::Visitor>::visit_nested_item
  30: rustc_hir::intravisit::walk_mod::>
  31:  as rustc_hir::intravisit::Visitor>::visit_mod
  32: rustc_lint::late::late_lint_pass_crate::
  33: rustc_lint::late::late_lint_crate::
  34: ::time::<(), rustc_lint::late::check_crate::{closure#0}::{closure#0}>
  35: ::time::<(), rustc_interface::passes::analysis::{closure#5}::{closure#0}::{closure#2}::{closure#0}>
  36:  as core::ops::function::FnOnce<()>>::call_once
  37: ::time::<(), rustc_interface::passes::analysis::{closure#5}>
  38: rustc_interface::passes::analysis
  39: >::with_task::>
  40: rustc_query_system::query::plumbing::try_execute_query::>>
  41: rustc_query_system::query::plumbing::get_query::
  42: ::enter::>
  43: ::enter::, rustc_errors::ErrorGuaranteed>>
  44: rustc_span::with_source_map::, rustc_interface::interface::create_compiler_and_run, rustc_driver::run_compiler::{closure#1}>::{closure#1}>
  45: >::set::, rustc_driver::run_compiler::{closure#1}>::{closure#0}, core::result::Result<(), rustc_errors::ErrorGuaranteed>>
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

[fasterthanlime]

Update: cargo clippy passes successfully on that same codebase, with Rust nightly 2022-04-12.

[Jarcho]

I guess the sync was a day or two late then.

[giraffate]

Thanks for the reports!

I'm closing this because it seems to be resolved in #8662 (comment). If any problems happens about this, feel free to reopen or comment.