Skip to content

[build] clippy doesn't run in some integration tests #4719

Closed
@tesuji

Description

@tesuji

Some integration tests use virtual workspace will not be tested by clippy:

Error from integration test of future-rs:

$ cargo clippy --all-targets --all-features -- --cap-lints warn -W clippy::pedantic -W clippy::nursery
error: --all-features is not allowed in the root of a virtual workspace

What should we do with it?

  1. Drop the --all-features flag?
  2. Specify a MANIFEST_PATH env for each crate has virtual workspace and pass it to each cargo clippy invocation?

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-infraArea: CI issues and issues that require full access for GitHub/CI

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions