Skip to content

uninlined_format_args should have stayed in pedantic #15151

Open
@IceSentry

Description

@IceSentry

Description

Format args currently don't support field access. This means you are forced to use uninlined format args when you need field access. Since I commonly mix field access and variables it means I would be forced to mix and match inlined and uninlined format args all over the place. For this reason I don't inline anything because I would always end up refactoring my format args.

Moving this lint to style now means we are forced by default to mix 2 formatting styles and constantly refactor format strings when needing field access. This feels like a very pedantic thing to warn about. I don't understand why it was moved to style.

Until field access is possible inside format args warning on this in every codebase is going to generate a lot of noise for very little gain.

Inlining everything can also generate really long strings which breaks rustfmt which is not great. There's also issues like this where inlining everything isn't really nice #14686

I think this lint was moved to style prematurely.

Version

rust 1.88

Additional Labels

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions