Skip to content

collapsible_if shouldn't warn on else after multiple else if #1401

Closed
@leoyvens

Description

@leoyvens

Consider:

if cond {
  ...
} else if cond1 {
  bar
} else if cond2 {
  ...
} else if cond3 {
  ...
} else {
  bar
}

This will trigger collapsible_if because of two equal bodies containing bar, but collapsing those ifs would be ugly and error prone, the code is idiomatic as it is.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions