Skip to content

[Project Goal, Help Wanted] Optimizing MSRV attribute collection #13169

Closed
@blyxyas

Description

@blyxyas

Currently, when knowing if the MSRV is high enough to run a lint, we're doing lots of repeated work.
We visit the same attributes a lot of times with the extract_msrv_attr! (specifically, the number of lints that use MSRVs, so a good number of dozens).

A possible solution to this would be precomputing the MSRV by DefId, as there can be more than a single clippy::msrv attribute on a single module.

Additional resources:

Metadata

Metadata

Assignees

No one assigned

    Labels

    E-mediumCall for participation: Medium difficulty level problem and requires some initial experience.performance-projectFor issues and PRs related to the Clippy Performance Project

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions