if let true = k > 1 {} and if let true = true {}

[Linus-Schwarz]

What it does

Warn you that this is bad style, recommend removing the let binding

Advantage

Clearly, it is not idiomatic to use refutable pattern matching on booleans

Drawbacks

None as far as I know

Example

let k = 5;
if let true = k > 1 { /* */ }

Could be written as:

let k = 5;
if k > 1 { /* */ }

AND

if let true = true { /* some code */ }

Could be written as:

/* some code */

AND

if let true = false { /* some code */ }

Should trigger an unreachable code warning

[Centri3]

We don't need to handle true = false specifically. Just suggesting if false should be good enough and makes it clearer that it's unreachable

We should also handle if let false, correct?

[Linus-Schwarz]

I agree, just simplifying if let true = some_condition to if some_condition and if let false = some_condition to if !some_condition (or if !(some_condition), depending on whether parentheses are needed) should be enough for other rules to kick in