Incorrect auto-fix: comparison to `false` breaks

[black-puppydog]

I just stumbled over this and think the test cases specify the wrong behaviour.
This line:

rust-clippy/tests/ui/bool_assert_comparison.rs

Line 89 in 8a98609

assert_eq!("a".is_empty(), false);

Gets turned into this:

rust-clippy/tests/ui/bool_assert_comparison.fixed

Line 89 in 8a98609

assert!("a".is_empty());

But these are opposite asserts, so this will break the test.

The same applies to all the other calls to assert_eq!(..., false) and assert_neq!(..., true) of course.

Edit: sorry for the lack of template, I created this from the GH blame view which seems so sidestep that.

Minimal Reproducer

fn main() {
    println!("Hello, world!");
}

#[cfg(test)]
mod test {
    #[test]
    fn assert_correctly_transformed() {
        let must_be_false = false;

        assert_eq!(must_be_false, false);
    }
}

Expected:

        assert!(!must_be_false);

Observed:

        assert!(must_be_false);

(note the lack of !)

clippy 0.1.69 (658fad6 2023-02-03)

This does NOT happen on stable (yet) since the auto-fix was only introduced recently.

[black-puppydog]

Tagging @Alexendoo as the author (in 5f49808 )